Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto change quality #341

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Auto change quality #341

wants to merge 22 commits into from

Conversation

Yemeni
Copy link
Collaborator

@Yemeni Yemeni commented Sep 16, 2020

  • Added video qualities to Upload model
  • able to upload videos then ffmpeg will convert them to different qualities
  • after new converted quality is done, it will update the model database
  • able to choose from converted qualities

@Yemeni Yemeni requested a review from mayeaux September 16, 2020 23:37
mayeaux
mayeaux reviewed Sep 17, 2020
View reviewed changes
views/media.pug Outdated Show resolved Hide resolved
Yemeni
Yemeni commented Sep 17, 2020
View reviewed changes
Copy link
Collaborator Author

@Yemeni Yemeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed playsinline

@Yemeni Yemeni mentioned this pull request Sep 17, 2020
Open
@Yemeni
Copy link
Collaborator Author

Yemeni commented Sep 22, 2020

what's remaining in order for perfection

  • notify all subscribers should be done on the queue itself if all qualities are ready
  • queue should be 1 per session/ per user, there is a tag thingy on bull that I still haven't checked it

@Yemeni Yemeni requested a review from mayeaux September 26, 2020 18:19
@Yemeni
Copy link
Collaborator Author

Yemeni commented Sep 26, 2020

with the new importer function, I think it will be better if we separate upload and converting qualities so that importer can use it too

@andrecsmenezes andrecsmenezes mentioned this pull request Feb 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayeaux mayeaux Awaiting requested review from mayeaux

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yemeni @mayeaux